Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stages and steps need clarification for the end user #47

Closed
karthik opened this issue May 7, 2018 · 7 comments
Closed

Stages and steps need clarification for the end user #47

karthik opened this issue May 7, 2018 · 7 comments
Labels

Comments

@karthik
Copy link
Member

karthik commented May 7, 2018

tic embraces this concept. Each stage has a name (e.g., "after_success", "deploy", ...) and has an arbitrary number of steps.

The documentation needs to address how a user makes sense of after_success and say deploy. e.g. if a user were to use this to build package docs with pkgdown, then on success, they would include the recipe to "deploy" the docs to a branch. Then where does deploy come into play since we just deployed under after_success. This type of ambiguity needs clarification since we cannot assume the end user understands these stages.

@krlmlr
Copy link
Collaborator

krlmlr commented May 7, 2018

  • function that emulates a Travis/Appveyor run
  • reduce steps to lcd between Travis/Appveyor
  • flow chart?
  • figure in the middle of http://ctlente.com/en/purrr-magic/: .travis.yml -> tic.R -> code

deploy: failure aborts build
after_success: failure does nothing

  • introductory video

  • assume existing user with knowledge about Travis CI and .travis.yml

@maelle
Copy link
Member

maelle commented Jun 13, 2018

A flow chart would be really useful (for this but also in general actually, so probably several flowcharts?).

@maelle
Copy link
Member

maelle commented Jun 13, 2018

When I say in general I mean the general concept of using GitHub and Travis CI to deploy "stuff".

@krlmlr
Copy link
Collaborator

krlmlr commented Jun 27, 2018

We could point users new to Travis CI to e.g. http://mahugh.com/2016/09/02/travis-ci-for-test-automation/.

The "build lifecycle" is described at https://docs.travis-ci.com/user/customizing-the-build#The-Build-Lifecycle, but they don't have a flow chart and the description isn't particularly detailed (e.g. it doesn't explain that failures in after_install etc. don't trigger a failed build). I couldn't find anything similar for AppVeyor. Maybe upstream needs better documentation too.

I have created https://github.com/krlmlr/ci-lifecycle to test various failure modes in the Travis CI and AppVeyor lifecycles, this repo could also host a more detailed description and the flow charts.

@krlmlr
Copy link
Collaborator

krlmlr commented Jun 27, 2018

Build in the ci-lifecycle repo: https://travis-ci.org/krlmlr/ci-lifecycle/builds/397482622

screenshot from 2018-06-27 20-54-25

@krlmlr krlmlr added the docs label Jun 27, 2018
@krlmlr
Copy link
Collaborator

krlmlr commented Jun 28, 2018

Closing in favor of #57, which contains the structure of a new vignette to be written. Happy to continue discussion there.

@krlmlr krlmlr closed this as completed Jun 28, 2018
@krlmlr
Copy link
Collaborator

krlmlr commented Jun 28, 2018

#57 incorporates most of the topics discussed here, some are solved already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants