Make tidync understand CF time dimension #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Errors upon submission of the PR seem to be related to an infrastructure upgrade at GitHub that isn't fully functional yet. |
|
awesome, very much appreciated - passes check and revdeps pass as well (on linux at least) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Many NetCDF files encode a "time" dimension using the COARDS and CF conventions: define a datum and apply offsets to it. Given the complexity of the different calendars, tidync currently does not support time decoding and displays the bare offsets. By importing package CFtime support for offset decoding into an intelligible time representation is now possible.
The main changes are in
hyper_transforms.R, where the offset decoding takes place, andhyper_array.R, wheredimnames()are assigned to the arrays as they are read from the NetCDF files. Further, minor changes are intidync.R(exposing the attributes in thetidyncclass) andhyper_tibble.R(easier population of dimension name columns).Related Issue
This patch fixes issue #54.