Refactor and rename internal functions #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I realized that I could make the function simpler so that future me could look at it and say "ah yes, that makes perfect sense" and now I have... and I realize I might be able to make it _even simpler_
maelle
approved these changes
May 24, 2021
R/asis-nodes.R
Outdated
| fix_fully_inline(imath), | ||
| FUN = function(n) xml2::xml_ns_strip(xml2::xml_children(n)) | ||
| ) | ||
| new_nodes <- lapply(imath, fix_fully_inline) |
There was a problem hiding this comment.
given the package depends on purrr, should we use it here?
There was a problem hiding this comment.
That's a good point for consistency's sake!
From Maëlle's review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes the unweildy and unhelpful pair of
set_default_space()andchar_to_nodelist()and renames them tomake_text_nodes(), simplifying and refactoring much of the code along the way.