Fix inline math with code #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will cause things like 10$? to break, but I think these kinds of things are rare enough to allow for things like $\beta$, to be valid
|
Note, while this PR will fix #56, there is still the problem of math and links that begin a line: library(tinkr)
ex <- "- so $\\beta^2 = `r runif(1)`$ works but,\n- $\\beta$ has the first dollar escaped"
f <- textConnection(ex)
y <- yarn$new(f)
close(f)
y$protect_math()$show()
#> - so $\beta^2 = `r runif(1)`$ works but,
#> - \$\beta$ has the first dollar escapedCreated on 2021-10-15 by the reprex package (v2.0.1) |
maelle
approved these changes
Oct 18, 2021
| @@ -20,6 +20,8 @@ | |||
| sink to the bottom of the document. | |||
| * 2021-09-14: numeric options fig.width and fig.height will no longer be quoted; | |||
| `transform_params()` is simplified and no longer requires glue. | |||
| * 2021-10-15: math with embedded code and punctuation following are now allowed | |||
R/asis-nodes.R
Outdated
| # a space or another dollar. | ||
| start <- glue::glue("(?=^|{punks})[$]?[$][^{ace}$]") | ||
| # a space, a dollar sign, or any possible adjacent punctuation. | ||
| no_punks <- glue::glue("{minus_maybe}[^]}}>){ace},;.?$-])") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the regex so that
$,is no longer considered to be a starting element and adds an "ambiguous" flag that can be checked for the presence of a code block immediately preceding.Created on 2021-10-15 by the reprex package (v2.0.1)
this will fix #56