add tasklist template for commonmark 1.8 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commonmark spec updated to include tasklists https://github.github.com/gfm/#task-list-items-extension- This was implemented in commonmark 1.8 with r-lib/commonmark#18. This commit should be backwards compatible with older versions of commonmark This will fix #66
maelle
approved these changes
Mar 24, 2022
| @@ -1,4 +1,11 @@ | |||
| # tinkr dev | |||
| # tinkr 0.0.0.9002 | |||
There was a problem hiding this comment.
You're so good at versioning that you might enjoy using fledge? https://cynkra.github.io/fledge/
There was a problem hiding this comment.
Ooh! Thank you for this! I completely forgot about it!
R/to_xml.R
Outdated
| body <- protect_tickbox(body, md_ns()) | ||
| if (utils::packageVersion("commonmark") < "1.8.0") { | ||
| #nocov start | ||
| body <- protect_tickbox(body, md_ns()) |
There was a problem hiding this comment.
as it's one line maybe rather just use # nocov at the end of it?
There was a problem hiding this comment.
I didn't know we could do that 😲
There was a problem hiding this comment.
I'm not sure I'm proud to know a further covr avoidance hack 😉
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commonmark spec updated to include tasklists
https://github.github.com/gfm/#task-list-items-extension-
This was implemented in commonmark 1.8 with
r-lib/commonmark#18. This PR should be
backwards compatible with older versions of commonmark
This will fix #66