Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't escape relative link anchors #86

Merged
merged 6 commits into from
Jan 26, 2023
Merged

don't escape relative link anchors #86

merged 6 commits into from
Jan 26, 2023

Conversation

zkamvar
Copy link
Member

@zkamvar zkamvar commented Jan 25, 2023

This will address #85 by not escaping relative link anchors if they have escapable characters.

Since these are not rendred by markdown to HTML, there is no reason to escape them, thus this pattern will now work:

here is a [linke that we use an underscore in][underscored_link]. It will not
be escaped when we roundtrip with {tinkr}!

[underscored_link]: https://github.com/ropensci/tinkr/issues/85

Copy link
Member

@maelle maelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 especially as this touches the xsl file!

NEWS.md Outdated Show resolved Hide resolved
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants