-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rm dependency on stringr #88
Conversation
@@ -0,0 +1,26 @@ | |||
# Replacements for stringr functions | |||
# to preserve the argument order + nice name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I absolutely love this solution! 💯
str_replace(string, pattern, "") | ||
} | ||
|
||
str_remove_all <- function(string, pattern) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't use this function, but I'm okay keeping it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YESSSSSS! 🎉
Why do we need {stringr} when we have tinkr::yarn
🧶 😝?
I was slightly dreading the difficulty of this, but the solution you came up with is spot on and really straightforward!
I have one request: please add a NEWS item 🙏🏼
The commit history furthermore shows how easy it was for me. 🤪
Done! |
Fix #87