New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using long vectors #21

Closed

lmullen opened this issue Aug 12, 2016 · 1 comment

Member

lmullen commented Aug 12, 2016

From rOpenSci onboarding:

https://github.com/lmullen/tokenizers/blob/d240cddbb1d91146b3a30b90f6fc25abd6919edf/src/skip_ngrams.cpp#L9: If you want to support long vectors in R, you likely want to return and use R_xlen_t for indexing.

Contributor

dselivanov commented Aug 25, 2016

IMHO we are safe and should close this issue. Can't imagine the case when it can be useful to use skip_grams > 10

lmullen closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment