Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More informative error message when user supplies non data.frame object to vis_dat #101

Closed
thisisnic opened this issue Nov 12, 2018 · 2 comments

Comments

@thisisnic
Copy link
Contributor

I was trying out visdat::vis_dat for the first time (great package!) and supplied datasets::AirPassengers as the x argument (I mistakenly thought it was a data frame and not a time series).

visdat::vis_dat(AirPassengers)

The error returned was:

Error in if (ncol(x) * nrow(x) > large_data_size && warn_large_data) { :
missing value where TRUE/FALSE needed

I was wondering if it would be worth having an error message which warns the user that they should be supplying a data.frame object?

(Happy to submit a PR myself if you'd like)

@njtierney
Copy link
Collaborator

Hello!

Thanks for writing an issue :)

I think that this is a great idea, I would welcome a PR for this, let me know if you want a hand with anything :)

@thisisnic
Copy link
Contributor Author

Thanks! :) I think I've done it - but as this is my second ever PR and I'm giving a talk soon about submitting PRs for newbies, any feedback is welcomed (with pedantry actively encouraged!)

njtierney added a commit that referenced this issue Nov 28, 2018
Fix #101 - throw an error if the x argument supplied to vis_dat is not a data.frame
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants