Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output of plot is now ordered by the original column names #134

Merged
merged 3 commits into from
Jul 5, 2021

Conversation

muschellij2
Copy link
Contributor

Fixes #133. Factors the column name.

Thought - maybe have a warning if rows or variable, valueType are included in the original data to give a warning as these will be silently removed due to reshaping.

@muschellij2
Copy link
Contributor Author

The failure seems to be a change in tibble::tribble implementation (likely from vctrs)

@njtierney
Copy link
Collaborator

Thanks so much for this, @muschellij2

Sorry I haven't gotten to this sooner. Taking a look now.

@njtierney njtierney merged commit 7a67b4c into ropensci:master Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vis_expect reorders columns.
2 participants