Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update description #53

Merged
merged 19 commits into from
Mar 5, 2019
Merged

Update description #53

merged 19 commits into from
Mar 5, 2019

Conversation

peterdesmet
Copy link
Member

Update description of package in README and DESCRIPTION (in part based on eel blog post). It now states:

wateRinfo facilitates access to waterinfo.be, a website managed by the Flanders Environment Agency (VMM) and Flanders Hydraulics Research. The website provides access to real-time water and weather related environmental variables for Flanders (Belgium), such as rainfall, air pressure, discharge, and water level. The package provides functions to search for stations and variables, and download time series.

The PR also includes:

  • Adding a To get started, see: (cf. bioRad or rgbif) in README with links to function reference and articles (until now, there was no link to website)
  • Updating _pkgdown.yml so these sections are called Reference and Articles in that order. The website has not been regenerated yet.

Copy link
Collaborator

@stijnvanhoey stijnvanhoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestions! I would rather prefer to keep some elements asa they were before. Can you update the website pages itself?

We'll need to fix the unit test issue, but these has nothing to do with your additions, so you can ignore these and we'll do a fix in a separate branch.

_pkgdown.yml Outdated Show resolved Hide resolved
_pkgdown.yml Show resolved Hide resolved
@stijnvanhoey
Copy link
Collaborator

We still need to update the website itself before merging.

@peterdesmet
Copy link
Member Author

Site generated. 👌

@stijnvanhoey stijnvanhoey merged commit 829649f into master Mar 5, 2019
@stijnvanhoey stijnvanhoey deleted the update_description branch March 5, 2019 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants