Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_data_drill() only returns outputs for rounded coordinates #57

Closed
max578 opened this issue Mar 4, 2024 · 2 comments
Closed

get_data_drill() only returns outputs for rounded coordinates #57

max578 opened this issue Mar 4, 2024 · 2 comments

Comments

@max578
Copy link

max578 commented Mar 4, 2024

Describe the bug
get_data_drill only returns a request for rounded coordinates.

To Reproduce

wd0 <- get_data_drill(
   latitude = -27.85,
   longitude = 150.05,
   start_date = "20221001",
   end_date = "20221003",
   values = c("max_temp", "min_temp", "rain"),
   api_key = "max.moldovan@gmail.com"
)

wd1 <- get_data_drill(
   latitude = -27.85,
   longitude = 150.05,
   start_date = "20221001",
   end_date = "20221003",
   values = c("max_temp", "min_temp", "rain"),
   api_key = "max.moldovan@gmail.com"
)

identical(wd0, wd1)

Expected behavior
The output for SILO should be at the 0.05x0.05 degree resolution.

Screenshots
Screenshot 2024-03-04 at 3 33 42 pm

sessionInfo()
R version 4.3.1 (2023-06-16)
Platform: aarch64-apple-darwin20 (64-bit)
Running under: macOS Ventura 13.5

Matrix products: default
BLAS:   /Library/Frameworks/R.framework/Versions/4.3-arm64/Resources/lib/libRblas.0.dylib 
LAPACK: /Library/Frameworks/R.framework/Versions/4.3-arm64/Resources/lib/libRlapack.dylib;  LAPACK version 3.11.0

locale:
[1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8

time zone: Australia/Adelaide
tzcode source: internal

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
[1] weatherOz_0.0.1.9000

loaded via a namespace (and not attached):
 [1] compiler_4.3.1    R6_2.5.1          generics_0.1.3    tools_4.3.1       httpcode_0.3.0    curl_5.2.0        urltools_1.7.3    Rcpp_1.0.12      
 [9] lubridate_1.9.3   triebeard_0.4.1   crul_1.4.0        codetools_0.2-19  data.table_1.15.0 timechange_0.3.0  terra_1.7-71 

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@max578 max578 changed the title get_data_drill() only return outputs for rounded coordinates get_data_drill() only returns outputs for rounded coordinates Mar 4, 2024
@adamhsparks
Copy link
Member

Good catch! I'll see what I can find.

adamhsparks added a commit that referenced this issue Mar 5, 2024
@adamhsparks
Copy link
Member

Found the issue and have patched it. Thank you for reporting it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants