Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function arguments are inconsistent #8

Closed
adamhsparks opened this issue Mar 31, 2023 · 1 comment
Closed

Function arguments are inconsistent #8

adamhsparks opened this issue Mar 31, 2023 · 1 comment

Comments

@adamhsparks
Copy link
Member

get_dpird_summaries() takes dates as "yyyy-mm-dd" while get_silo() takes dates as "yyyymmdd".

These should be a standard format across all functions in the package.
@bozaah
Copy link
Collaborator

bozaah commented Mar 31, 2023 •
edited
Loading

.check.date() has the functionally we need. I have maintained "yyyymmdd" date format from get_silo().
I have also added Sys.timezone() as an argument to .check_date(). Commit 7784f9d fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adamhsparks @bozaah