Adds functionality to find stations in a geographic area #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Finally, I think it's passing all checks and the vignettes are rebuilt. This is ready for review and merging. |
|
I've spent some time with the vignettes in this PR as well, it's a bit messy with major additions and these edits but everything lines up and these additions necessitated changes to the vignettes, so it works out. |
bozaah
approved these changes
May 29, 2024
There was a problem hiding this comment.
Thanks @adamhsparks! Great addition with find_stations_in() and additional (tons of it!) work with the tests, re-doc and re-building of the vignettes. I have run the checks and everything works as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new function,
find_stations_in(), which can take a bounding box or a geospatial data set of polygon(s) and return stations either that fall within those boundaries or the station nearest the centroid(s).This adds two new imports, {sf} (already installed with the {stars} import), and {osmdata} to derive a bounding box for a named place.
I've added full documentation including updating the vingettes and tests.
The vingettees have not yet been rebuilt due to this bug in {curl} jeroen/curl#338 (comment), but functionally the package is ready to go, I think.