Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cir_query fails with whitespace search strings #146

Closed
3 tasks done
eduardszoecs opened this issue Apr 7, 2018 · 1 comment
Closed
3 tasks done

cir_query fails with whitespace search strings #146

eduardszoecs opened this issue Apr 7, 2018 · 1 comment
Assignees
Labels
bug Unexpected problem or unintended behavior

Comments

@eduardszoecs
Copy link
Member

eduardszoecs commented Apr 7, 2018

Bug report by a user:

Hello Eduard
I think your R package webchem is really great and i use it a lot. However, I have one addition to the documentation that you could consider adding.

In the cir_query, you only list chemical names without whitespace and that works fine, but if you have chemicals such as acetic acid, it doesn't work. But by searching for acetic%20acid, the correct chemical is found. It took some time for me to wrap my head around this and maybe there are others that could benefit from this info. It would be pretty easy to add a gsub substituting the whitespace, so it could be something you could consider for our next update.

Best regards
Lasse Nielsen

  • cir_query
  • check & fix other functions
  • add tests
@eduardszoecs eduardszoecs added the bug Unexpected problem or unintended behavior label Apr 7, 2018
@eduardszoecs eduardszoecs self-assigned this Apr 7, 2018
eduardszoecs added a commit that referenced this issue Apr 7, 2018
eduardszoecs added a commit that referenced this issue Apr 7, 2018
eduardszoecs added a commit that referenced this issue Apr 7, 2018
eduardszoecs added a commit that referenced this issue Apr 7, 2018
eduardszoecs added a commit that referenced this issue Apr 7, 2018
@eduardszoecs
Copy link
Member Author

Thanks for report.
This you true for several webchem functions.
Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

1 participant