Fixed stripping of . from extracted numbers #136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now numbers are not extracted corrected.
For examples in pp_query.
`extr_num("Melting Pt : -44.6 deg C")` strips the "." and gives -446.
My fix keeps "."'s. It will fail if there is a dot in another place though.
`extr_num("Melting Pt : -44.6 deg C.")` gives NA.
Alternatively you could use `readr::parse_number` that also handles that.
|
Hmm. This strips the - instead. |
|
OK fixed that. |
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
=======================================
Coverage ? 0%
=======================================
Files ? 17
Lines ? 1622
Branches ? 0
=======================================
Hits ? 0
Misses ? 1622
Partials ? 0
Continue to review full report at Codecov.
|
Evidently CS is sometimes not escaping properly special characters. Here is a fix for the problem I found. I could not find a general way to fix this. I guess if there was one parsers would do it.
Some chemspider records are missing epiSuite data. For those the parsing will fail.
|
Cherry-picked all suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now numbers are not extracted corrected.
For examples in pp_query.
extr_num("Melting Pt : -44.6 deg C")strips the "." and gives -446.My fix keeps "."'s. It will fail if there is a dot in another place though.
extr_num("Melting Pt : -44.6 deg C.")gives NA.Alternatively you could use
readr::parse_numberthat also handles that.