Added robustness to parsing of values that might be missing. #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the current code when a value is not found it returns `numeric(0)` which has length 0. SO when added to the vector things get out of sync. Example that triggers the bug: http://www.chemspider.com/Chemical-Structure.391783.html I didn't fix for all the properties but I think everything can be fixed the same way.
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
=======================================
Coverage ? 0%
=======================================
Files ? 17
Lines ? 1630
Branches ? 0
=======================================
Hits ? 0
Misses ? 1630
Partials ? 0
Continue to review full report at Codecov.
|
eduardszoecs
added a commit
that referenced
this pull request
Feb 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current code when a value is not found it returns
numeric(0)which has length 0. SO when added to the vector things get out of sync.Example that triggers the bug: http://www.chemspider.com/Chemical-Structure.391783.html
I didn't fix for all the properties but I think everything can be fixed the same way.