New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIST retention indices #154
Conversation
…s regarding variables not existing in global environment. Combined several short functions into one long one.
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
=====================================
Coverage 0% 0%
=====================================
Files 17 18 +1
Lines 1567 1665 +98
=====================================
- Misses 1567 1665 +98
Continue to review full report at Codecov.
|
Thanks for your contribution! I'll merge ASAP, add tests and clean it a bit (I might also change the function name). |
Didn't have time these week. On my table for the next 3 days... |
Thanks @Aariq for your contribution. Now merged into Note that I
|
Yay! Thanks for helping with those last few steps. You could even name it |
renamed. |
Pull Request
This adds a function,
get_RI()
to scrape retention indices from webbook.nist.gov given a vector of CAS numbers. It returns a single table with rows for each entry of each CAS number. It's then easy to filter, summarize, extract single rows, etc. I haven't added tests because I'm not familiar withtestthat
. I'd be happy to learn, but I don't have time for the next few weeks.I also know you want to keep dependencies to a minimum, so please let me know if I need to get rid of dependencies to
purrr
andstringr
since I don't think webchem already uses those. I can probably translate to base R without too much difficulty.PR task list:
devtools::document()