Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIST retention indices #154

Merged
merged 3 commits into from Jun 24, 2018
Merged

NIST retention indices #154

merged 3 commits into from Jun 24, 2018

Conversation

Aariq
Copy link
Collaborator

@Aariq Aariq commented Jun 14, 2018

Pull Request


This adds a function, get_RI() to scrape retention indices from webbook.nist.gov given a vector of CAS numbers. It returns a single table with rows for each entry of each CAS number. It's then easy to filter, summarize, extract single rows, etc. I haven't added tests because I'm not familiar with testthat. I'd be happy to learn, but I don't have time for the next few weeks.
I also know you want to keep dependencies to a minimum, so please let me know if I need to get rid of dependencies to purrr and stringr since I don't think webchem already uses those. I can probably translate to base R without too much difficulty.

myRIs <- get_RI(cas = c("78-70-6", "873-94-9", "13474-59-4"), type = "linear", polarity = "non-polar", temp_prog = "ramp")

PR task list:

  • Update NEWS
  • Add tests (if appropriate)
  • Update documentation with devtools::document()
  • Check package passed

…s regarding variables not existing in global environment. Combined several short functions into one long one.
@codecov-io
Copy link

codecov-io commented Jun 14, 2018

Codecov Report

Merging #154 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #154   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files          17     18    +1     
  Lines        1567   1665   +98     
=====================================
- Misses       1567   1665   +98
Impacted Files Coverage Δ
R/NIST.R 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e1c1f8...328e96e. Read the comment docs.

@eduardszoecs
Copy link
Member

Thanks for your contribution!

I'll merge ASAP, add tests and clean it a bit (I might also change the function name).
Timewise, I'll be able to do so later this week! (Also busy with job).

@eduardszoecs
Copy link
Member

Didn't have time these week. On my table for the next 3 days...

This was referenced Jun 24, 2018
@eduardszoecs eduardszoecs merged commit 328e96e into ropensci:master Jun 24, 2018
@eduardszoecs
Copy link
Member

eduardszoecs commented Jun 24, 2018

  • merge into dev_nist
  • cleanup code
  • updated documentation
  • add tests
  • check
  • merge into master
  • merge into tests
  • Check CI
  • Check coverage

Thanks @Aariq for your contribution. Now merged into master (all tests pass)

Note that I

  1. renamed to get_ri()
  2. did basic cleanup
  3. added you as contributor to the readme
  4. added tests
  5. updated documentation on your function

@Aariq Aariq deleted the dev_eric2 branch June 24, 2018 21:53
@Aariq
Copy link
Collaborator Author

Aariq commented Jun 24, 2018

Yay! Thanks for helping with those last few steps. You could even name it nist_ri(). I noticed the section in your contribution guidelines about naming functions only after the pull request, and I'm not particularly tied to get_ri() for any reason.

@eduardszoecs
Copy link
Member

renamed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants