updated get_csid() to handle new ChemSpider API #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
=====================================
Coverage 0% 0%
=====================================
Files 18 18
Lines 1668 1658 -10
=====================================
+ Misses 1668 1658 -10
Continue to review full report at Codecov.
|
eduardszoecs
requested changes
Apr 3, 2019
Thanks, this is much more elegant. Tested, works. Co-Authored-By: stitam <49147718+stitam@users.noreply.github.com>
|
R CMD check succeeded, I am clueless with this Travis error, any help would be appreciated. |
|
Don't know what's wrong with travis, but this looks really good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of files seem like they changed, it's because of the devtools::document(). I only worked with the chemspider.R and DESCRIPTION files.