New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing PubChem PUG-View web service #230
Conversation
Merge remote-tracking branch 'upstream/master' into pubchem # Conflicts: # R/chebi.R
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function works exactly how I'd expect it to from your description. I think it's a great addition to the package. I have a few documentation requests and some other code suggestions that you can take or leave.
I updated the PR based on @Aariq's comments. The package is still not building, I think this has to do with AppVeyor being unable to check the examples because some of the webservices are down. |
The Pubchem PUG-View web service allows the programmer to access information from the PubChem content pages (e.g. https://pubchem.ncbi.nlm.nih.gov/compound/176). The proposed function which implements this functionality is
pc_sect()
as it accesses a section of the content pages (I struggled with naming this function so I am open to suggestions). An example:This returns a tibble of pKa a values. Under the hood the function uses
pc_page()
to retrieve a list of content pages andpc_extract()
to extract information from these content pages and assemble the tibble.Some issues I feel we should discuss:
webchem_submit()
(now renamed tosubmit_request()
) to submit POST requests in a standardised manner. This function is an attempt to standardise all http requests in webchem. Do you think this function would help? Edit: removed the function, let's discuss this as a separate issue.pc_page()
andpc_extract()
use thedata.tree
package, which is a new dependency. It would be great not to depend on another package, but I couldn't navigate the content pages otherwise. Can you suggest an alternative?PR task list:
devtools::document()