Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final edits before v1.1 #298

Merged
merged 11 commits into from
Oct 1, 2020
Merged

Final edits before v1.1 #298

merged 11 commits into from
Oct 1, 2020

Conversation

stitam
Copy link
Contributor

@stitam stitam commented Oct 1, 2020

  • Added a startup message that points to the survey, let me know if you like it.
  • Removed authors from function documentation, if any authors have an issue with this, we can revert later.
  • Removed contributors from NEWS.md, if any contributors have an issue with this, we can revert later.

Any other quick fixes before we release v1.1?

@stitam stitam marked this pull request as draft October 1, 2020 07:22
@andschar
Copy link
Contributor

andschar commented Oct 1, 2020

Should we also include the wait time function from #287? I could file a PR for that and we have had a look at all the web services concerning their policies, though mostly without finding anything.

@stitam
Copy link
Contributor Author

stitam commented Oct 1, 2020

Should we also include the wait time function from #287? I could file a PR for that and we have had a look at all the web services concerning their policies, though mostly without finding anything.

Yeah, if you're almost ready with it, then sure, let's put it in. I'll merge this PR last so it is really "final edits":)

@andschar
Copy link
Contributor

andschar commented Oct 1, 2020

I have created PR #300

@stitam stitam marked this pull request as ready for review October 1, 2020 19:04
@stitam
Copy link
Contributor Author

stitam commented Oct 1, 2020

I have created PR #300

Just flagging that we have agreed within the PR discussion that we'll not include this PR in v1.1.

@stitam stitam merged commit 6433e7e into ropensci:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants