Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

429 errors with add_contributors() #38

Closed
sbfnk opened this issue May 14, 2024 · 3 comments
Closed

429 errors with add_contributors() #38

sbfnk opened this issue May 14, 2024 · 3 comments

Comments

@sbfnk
Copy link

sbfnk commented May 14, 2024

We're running into 429 errors (too many requests) with add_contributors() and tracked this down to the check_github_urls() call. A simple remedy would be to expose the check_urls argument to add_contributors().

This issue is causing epiforecasts/EpiNow2#664

@mpadge
Copy link
Member

mpadge commented May 14, 2024

Just implemented a better work-around for a similar 429 error in ropensci-review-tools/dashboard@c70e7af. I'll copy that code over here to fix. Thanks for the heads-up!

@sbfnk
Copy link
Author

sbfnk commented May 14, 2024

Great, thanks!

@mpadge
Copy link
Member

mpadge commented May 15, 2024

@sbfnk The check_urls parameter has now been exposed in the main add_contributors function, as you suggested, plus additional error handling implemented for the checking calls themselves. Any errors should now just "fail gracefully", and the call should proceed regardless.

These changes should be on an updated CRAN version soon.

mpadge added a commit that referenced this issue May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants