Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review: ColorProvider - hex color random_int fix #18

Closed
sckott opened this issue Mar 9, 2017 · 2 comments
Closed

review: ColorProvider - hex color random_int fix #18

sckott opened this issue Mar 9, 2017 · 2 comments
Labels
review
Milestone
v0.2

Comments

@sckott
Copy link
Collaborator

sckott commented Mar 9, 2017

Its hex-color generator users the random_int() method to choose a number between 1 and 16777215. The above noted behavior means it will never generate #ffffff, and the lower bound of 1 prevents #000000 from being generated too.

will fix
@sckott sckott added the review label Mar 9, 2017
@sckott sckott mentioned this issue Mar 9, 2017
Closed
13 tasks
@sckott sckott modified the milestone: v0.1 May 30, 2017
@sckott
Copy link
Collaborator Author

sckott commented May 30, 2017

I do what the python faker library does - do agree should make this change, but don't think it's super crucial, moving to next milestone

@sckott sckott modified the milestones: v0.2, v0.1 May 30, 2017
@sckott
Copy link
Collaborator Author

sckott commented May 30, 2017

https://stackoverflow.com/questions/8027423/how-to-check-if-a-string-is-a-valid-hex-color-representation regex hex color codes

@kylevoyto kylevoyto mentioned this issue May 15, 2018
Merged
@sckott sckott closed this as completed May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
review
Projects
None yet
Milestone
v0.2
Development

No branches or pull requests
1 participant
@sckott