Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review: fix MissingDataProvider #29

Closed
sckott opened this issue Mar 9, 2017 · 0 comments
Closed

review: fix MissingDataProvider #29

sckott opened this issue Mar 9, 2017 · 0 comments
Labels
review
Milestone
v0.1

Comments

@sckott
Copy link
Collaborator

sckott commented Mar 9, 2017

it's odd that the n missing values it generates for a vector overwrite the first n values. I feel like it should randomly determine n, sample() n position indices, and make the elements in those positions NA so that the NAs are scattered throughout the vector.
@sckott sckott added the review label Mar 9, 2017
@sckott sckott mentioned this issue Mar 9, 2017
Closed
13 tasks
@sckott sckott closed this as completed in f6c27ad Mar 28, 2017
@sckott sckott modified the milestone: v0.1 May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
review
Projects
None yet
Milestone
v0.1
Development

No branches or pull requests
1 participant
@sckott