Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating intermediate collections just to call foreach on them in the end (from bcode) #56

Open
romanowski opened this issue Feb 21, 2018 · 2 comments

Comments

@romanowski
Copy link
Collaborator

Example that represent the problem:

fieldSymbols function from here is producing List that is consumed here by only calling for each.

This particular example most likely will not produce significant improvements but I think it represent class of problems that can be fixed by strategic solution (like inlining or other optimization used during compilation of compiler code).

@mkeskells
Copy link
Collaborator

because of #58 it probably creating 2 lists per cycle

@mkeskells
Copy link
Collaborator

probably can get some info from the collections instrumentation - a :: accessed once only

pkukielka pushed a commit that referenced this issue Apr 30, 2018
Implement HashMap and TreeMap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants