Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacyModeNS? #14

Closed
chapulina opened this issue Jun 24, 2020 · 1 comment
Closed

Remove legacyModeNS? #14

chapulina opened this issue Jun 24, 2020 · 1 comment
Assignees
@ahcorde

Comments

@chapulina
Copy link
Collaborator

I saw that the legacyModeNS option has been migrated from ROS 1 to this package:

https://github.com/ros-simulation/gazebo_ros2_control/blob/a1318f8b1da9285ea3f647f575c1b37c1ef2975d/gazebo_ros2_control/src/gazebo_ros2_control_plugin.cpp#L179-L194

Given that option's name, I'd expect it to be the kind of thing that doesn't need to be perpetuated into ROS 2. Is that still necessary?
@ahcorde
Copy link
Collaborator

ahcorde commented Jun 24, 2020

#17

@ahcorde ahcorde self-assigned this Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahcorde @chapulina