Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mimic joint should have the same control mode as mimicked joint. #154

Merged
merged 4 commits into from
Nov 16, 2022
Merged

Mimic joint should have the same control mode as mimicked joint. #154

merged 4 commits into from
Nov 16, 2022

Conversation

destogl
Copy link
Member

@destogl destogl commented Oct 16, 2022

With this change gripper example works again.

@destogl destogl added the bug Something isn't working label Oct 16, 2022
@destogl destogl self-assigned this Oct 16, 2022
ahcorde
ahcorde requested changes Oct 18, 2022
View reviewed changes
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linters

@christophfroehlich
Copy link
Contributor

I also ran over this bug accidentally; but this PR works fine. And these small changes make the linter happy:
StoglRobotics-forks#1

@ahcorde ahcorde merged commit 563fdb7 into ros-controls:master Nov 16, 2022
@destogl destogl deleted the mimic-joint-same-control-mode-as-mimicked branch November 16, 2022 20:51
@destogl destogl mentioned this pull request Nov 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@bmagyar bmagyar Awaiting requested review from bmagyar

Assignees

@destogl destogl

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@destogl @christophfroehlich @ahcorde