Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove publish_rate parameter #179

Merged
merged 1 commit into from
May 16, 2023
Merged

Remove publish_rate parameter #179

merged 1 commit into from
May 16, 2023

Conversation

tonynajjar
Copy link
Contributor

@ahcorde
Copy link
Collaborator

ahcorde commented Feb 20, 2023

CI is failing, the service_msgs package was added 3 weeks ago https://github.com/ros2/rcl_interfaces/commits/rolling/service_msgs and it was released last week, maybe a package that uses this dependency is not released yet and that's why is failing?

@tonynajjar
Copy link
Contributor Author

tonynajjar commented Feb 24, 2023 •
edited
Loading

just to clarify, because that's unrelated to my PR, are you asking me the question? 😄

@ahcorde
Copy link
Collaborator

ahcorde commented May 12, 2023

@bmagyar or @destogl can you relaunch the Github actions ?

@ahcorde
Copy link
Collaborator

ahcorde commented May 12, 2023

just to clarify, because that's unrelated to my PR, are you asking me the question? smile

This was not a question, it was a clarification, but for some reason I added ?. Let's relaunch CI

@ahcorde ahcorde closed this May 16, 2023
@ahcorde ahcorde reopened this May 16, 2023
@bmagyar bmagyar merged commit 49ad216 into ros-controls:master May 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@bmagyar bmagyar bmagyar approved these changes

Assignees

@tonynajjar tonynajjar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tonynajjar @ahcorde @bmagyar