Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed rolling compilation #195

Merged
merged 2 commits into from
May 16, 2023
Merged

Fixed rolling compilation #195

merged 2 commits into from
May 16, 2023

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented May 16, 2023

Related with this issue in the buildfarm https://build.ros2.org/job/Hdev__gazebo_ros2_control__ubuntu_jammy_amd64/32/console

we use the same solution in gz_ros2_control

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde requested review from destogl and bmagyar May 16, 2023 13:19
@ahcorde ahcorde self-assigned this May 16, 2023
std::string robot_hw_sim_type_str_ = control_hardware_info[i].hardware_plugin_name;
#endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format!

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make a mental note to remove these once they reach critical mass... it's fairly easy to backport things with mergify

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde merged commit c311225 into master May 16, 2023
3 checks passed
@ahcorde ahcorde deleted the ahcorde/fix/rolling branch May 16, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants