Run end to end test in CI #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
christophfroehlich
approved these changes
Jun 8, 2023
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
…est_ci' into ahcorde/rolling/run_end_to_end_test_ci
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
bmagyar
reviewed
Jun 9, 2023
| @@ -49,7 +49,7 @@ jobs: | |||
| wget https://packages.osrfoundation.org/gazebo.gpg -O /usr/share/keyrings/pkgs-osrf-archive-keyring.gpg | |||
| echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/pkgs-osrf-archive-keyring.gpg] http://packages.osrfoundation.org/gazebo/ubuntu-stable $(lsb_release -cs) main" | tee /etc/apt/sources.list.d/gazebo-stable.list > /dev/null | |||
| if [ "$GZ_VERSION" == "garden" ]; then | |||
| export GZ_DEPS="libgz-sim7-dev libgz-plugin2-dev" | |||
| export GZ_DEPS="libgz-sim7-dev libgz-plugin2-dev gz-sim7-cli" | |||
There was a problem hiding this comment.
I think we should start using rosdep for these steps instead to save us some headache on the buildfarm later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the test but I didn't include the test in the CI. This PR should fix this