Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove plugin export (ROS 1 syntax) #158

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

christophfroehlich
Copy link
Contributor

I think that the pluginlib macros in the export section are not necessary any more, pluginlib_export_plugin_description_file in CMakeLists does the job. See the official docs:

@ahcorde ahcorde merged commit 223086d into ros-controls:master Jun 12, 2023
7 checks passed
@ahcorde
Copy link
Collaborator

ahcorde commented Jun 12, 2023

https://github.com/Mergifyio backport humble

@mergify
Copy link
Contributor

mergify bot commented Jun 12, 2023

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 12, 2023
(cherry picked from commit 223086d)

# Conflicts:
#	gz_ros2_control/package.xml
@christophfroehlich christophfroehlich deleted the fix_package_xml branch June 12, 2023 09:55
ahcorde added a commit that referenced this pull request Jun 12, 2023
* Remove plugin export from ROS 1 (#158)

(cherry picked from commit 223086d)

# Conflicts:
#	gz_ros2_control/package.xml

* Fixed merge

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>

---------

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants