Force setting use_sim_time parameter when using plugin. #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahcorde
requested changes
Nov 25, 2022
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
ahcorde
approved these changes
Nov 25, 2022
ahcorde
added a commit
that referenced
this pull request
Nov 25, 2022
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
ahcorde
added a commit
that referenced
this pull request
Nov 25, 2022
livanov93
pushed a commit
to livanov93/ign_ros2_control
that referenced
this pull request
Feb 22, 2023
…#100) Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
livanov93
pushed a commit
to livanov93/ign_ros2_control
that referenced
this pull request
Feb 22, 2023
…#100) (ros-controls#102) Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Denis Štogl <denis@stogl.de> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to force setting parameter for controller manager and controller so we don't have to adjust controllers.yaml file.
This will reduce user errors and make controllers.yaml file more compatible for other use-cases, e.g. when using Mock and real hardware.