Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch pluginlib exceptions #175

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Catch pluginlib exceptions #175

merged 2 commits into from
Aug 21, 2023

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Aug 21, 2023

Related with this PR in gazebo_ros2_control ros-controls/gazebo_ros2_control#229

@ahcorde
Catch pluginlib exceptions
9691562 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Aug 21, 2023
christophfroehlich
christophfroehlich approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the format issue, this LGTM!

@ahcorde
make linters happy
a5e87f1 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde merged commit a88a19a into master Aug 21, 2023
7 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/catch_pluginlib_exceptions branch August 21, 2023 08:07
@ahcorde
Copy link
Collaborator Author

ahcorde commented Aug 21, 2023

https://github.com/Mergifyio backport humble

@mergify
Copy link
Contributor

mergify bot commented Aug 21, 2023 •
edited
Loading

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 21, 2023
@ahcorde @mergify
Catch pluginlib exceptions (#175)
ab07160 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit a88a19a)

# Conflicts:
#	ign_ros2_control/src/ign_ros2_control_plugin.cpp
@mergify mergify bot mentioned this pull request Aug 21, 2023
Merged
ahcorde pushed a commit that referenced this pull request Aug 21, 2023
@mergify
Catch pluginlib exceptions (backport #175) (#176)
facbef4 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
ahcorde added a commit that referenced this pull request Aug 23, 2023
@ahcorde
Catch pluginlib exceptions (#175)
3747d32 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophfroehlich christophfroehlich christophfroehlich approved these changes

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahcorde @christophfroehlich