Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Harmonic #185

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Support Harmonic #185

merged 3 commits into from
Oct 10, 2023

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Oct 4, 2023

No description provided.

@ahcorde
Support Harmonic
8eb5d8b 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Oct 4, 2023
christophfroehlich
christophfroehlich requested changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine, but could you also please update the table at the top of the readme.md?

@christophfroehlich
Copy link
Contributor

christophfroehlich commented Oct 8, 2023 •
edited

Isn't it necessary to update something here

gz_ros2_control/gz_ros2_control_demos/package.xml

Line 39 in 1e80f42

<exec_depend condition="$GZ_VERSION == ''">ros_gz_sim</exec_depend>
and

gz_ros2_control/gz_ros2_control/package.xml

Line 15 in 1e80f42

<depend condition="$GZ_VERSION == ''">ignition-gazebo6</depend>

too?

@ahcorde
update packages.xml and README
e579c09 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
christophfroehlich
christophfroehlich approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
Another small suggestion: Should we add iron distro to the table, too? Seems to be equal to rolling according to the gazebo docs?

@ahcorde
Added Iron combinations to the table
749169b 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde merged commit f87306e into master Oct 10, 2023
7 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/support_harmonic branch October 10, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophfroehlich christophfroehlich christophfroehlich approved these changes

@bmagyar bmagyar Awaiting requested review from bmagyar

@destogl destogl Awaiting requested review from destogl

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahcorde @christophfroehlich