Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial_value not working #241

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

mrjogo
Copy link
Contributor

@mrjogo mrjogo commented Feb 23, 2024

Fixes #167 and UniversalRobots/Universal_Robots_ROS2_GZ_Simulation#14.

I verified the fix on the humble branch (I'm running Humble), but I'm unable to even compile the master branch, so I'd appreciate it if someone could verify that this works.

@ahcorde ahcorde merged commit c5b0b90 into ros-controls:master Feb 26, 2024
8 checks passed
@ahcorde
Copy link
Collaborator

ahcorde commented Feb 26, 2024

https://github.com/Mergifyio backport humble iron

Copy link
Contributor

mergify bot commented Feb 26, 2024

backport humble iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 26, 2024
(cherry picked from commit c5b0b90)

# Conflicts:
#	ign_ros2_control/src/ign_system.cpp
mergify bot pushed a commit that referenced this pull request Feb 26, 2024
ahcorde pushed a commit that referenced this pull request Feb 26, 2024
(cherry picked from commit c5b0b90)

Co-authored-by: Ruddick Lawrence <679360+mrjogo@users.noreply.github.com>
ahcorde added a commit that referenced this pull request Feb 27, 2024
* Reset Gazebo with initial joint positions and velocities (#241)

(cherry picked from commit c5b0b90)

# Conflicts:
#	ign_ros2_control/src/ign_system.cpp

* Fixed merge

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>

* Fix

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>

---------

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Ruddick Lawrence <679360+mrjogo@users.noreply.github.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@mrjogo mrjogo deleted the fix-initial-positions branch February 29, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure to set initial_value for position state interface when loading velocity controller
2 participants