Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<robot_param> and <robot_param_node> tags do not work with ign_ros2_control plugin #274

Closed
rachit-aggarwal opened this issue Apr 11, 2024 · 1 comment

Comments

@rachit-aggarwal
Copy link

I am currently using ROS Humble + Ign Fortress and trying to load ign_ros2_control plugin using Ign Fortress. I am defining my own robot param parameter node as shown below using the instructions in documentation (I changed the plugin to ign as I am using Fortress)

<plugin filename="ign_ros2_control-system" name="ign_ros2_control::IgnitionROS2ControlPlugin">
  <parameters>$(find my_description)/config/default_controller.yaml</parameters>
  <robot_param>robot_description</robot_param>
  <robot_param_node>my_robot_state_publisher</robot_param_node>
</plugin>

I get the following error:

[ERROR] [1712874118.400169640] [gz_ros2_control]: robot_state_publisher service not available, waiting again...

It seems that the plugin is trying to access param in default node name robot_state_publisher and not the prescribed node name my_robot_state_publisher. Upon looking up in the source, it seems that the plugin tags were never added. The same TODO is present in the master/rolling and iron branches.

Can the maintainers confirm issue of missing feature or help point out if I am missing something?

@ahcorde
Copy link
Collaborator

ahcorde commented Apr 19, 2024

@rachit-aggarwal This PR #275 should fix your issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants