Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added parameters robot_param and robot_param_node #275

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Added parameters robot_param and robot_param_node #275

merged 1 commit into from
Apr 24, 2024

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Apr 19, 2024

Related with this PR #274

Allow to use these two paramaters

<plugin filename="ign_ros2_control-system" name="ign_ros2_control::IgnitionROS2ControlPlugin">
  <parameters>$(find my_description)/config/default_controller.yaml</parameters>
  <robot_param>robot_description</robot_param>
  <robot_param_node>my_robot_state_publisher</robot_param_node>
</plugin>

@ahcorde
Added parameters robot_param and robot_param_node
b891940 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Apr 19, 2024
@ahcorde ahcorde mentioned this pull request Apr 19, 2024
Closed
christophfroehlich
christophfroehlich approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works, but if one configures a robot_param which is not available this results in a segfault.

@ahcorde ahcorde merged commit 53b6c74 into humble Apr 24, 2024
5 checks passed
@ahcorde ahcorde deleted the ahcorde/humble/robot_params branch April 24, 2024 16:05
@ahcorde
Copy link
Collaborator Author

ahcorde commented Apr 24, 2024

https://github.com/Mergifyio backport master iron

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 24, 2024 •
edited
Loading

backport master iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 24, 2024
@ahcorde @mergify
Added parameters robot_param and robot_param_node (#275)
99608c5 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 53b6c74)
mergify bot pushed a commit that referenced this pull request Apr 24, 2024
@ahcorde @mergify
Added parameters robot_param and robot_param_node (#275)
8d53d5c 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 53b6c74)
ahcorde added a commit that referenced this pull request Apr 24, 2024
@mergify @ahcorde
Added parameters robot_param and robot_param_node (#275) (#280)
c3f2a96 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 53b6c74)

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
ahcorde added a commit that referenced this pull request Apr 24, 2024
@mergify @ahcorde
Added parameters robot_param and robot_param_node (#275) (#281)
2919829 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 53b6c74)

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophfroehlich christophfroehlich christophfroehlich approved these changes

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahcorde @christophfroehlich