Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite mimic joints #276

Merged
merged 6 commits into from
Apr 23, 2024
Merged

Rewrite mimic joints #276

merged 6 commits into from
Apr 23, 2024

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Apr 22, 2024

Similar to ros-controls/gazebo_ros2_control#297

The component_parser of the resource_manager now already parses the mimic joint information from the URDF. The old way for defining it in the ros2_control tag is deprecated, see ros-controls/ros2_control#1256.

$ ros2 control list_hardware_interfaces
command interfaces
        right_finger_joint/position [available] [claimed]
state interfaces
        left_finger_joint/effort
        left_finger_joint/position
        left_finger_joint/velocity
        right_finger_joint/effort
        right_finger_joint/position
        right_finger_joint/velocity
$ ros2 topic echo /joint_states --once
header:
  stamp:
    sec: 61
    nanosec: 200000000
  frame_id: ''
name:
- right_finger_joint
- left_finger_joint
position:
- 0.15
- 0.1500000000000001
velocity:
- 0.0
- -1.1102230246251565e-14
effort:
- 0.0
- 0.0
---

Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small change, LGTM

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde merged commit d3e00a5 into master Apr 23, 2024
2 of 7 checks passed
@ahcorde ahcorde deleted the mimic_joints_rewrite branch April 23, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why don't you remove _mimic suffix?
3 participants