Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed target of ament_export_libraries #295

Merged
merged 1 commit into from
May 6, 2024
Merged

Fixed target of ament_export_libraries #295

merged 1 commit into from
May 6, 2024

Conversation

TakashiSato
Copy link
Contributor

Since a non-existent library was specified for export, a warning was generated as shown below when building packages that depend on gz_ros2_control.

CMake Warning at /home/ubuntu/ws_gz_ros2_control/install/gz_ros2_control/share/gz_ros2_control/cmake/ament_cmake_export_libraries-extras.cmake:116 (message):
  Package 'gz_ros2_control' exports library 'gz_ros2_control' which couldn't
  be found
Call Stack (most recent call first):
  /home/ubuntu/ws_gz_ros2_control/install/gz_ros2_control/share/gz_ros2_control/cmake/gz_ros2_controlConfig.cmake:41 (include)
  CMakeLists.txt:49 (find_package)

This pull request changes it to export the correct existing target.

@TakashiSato TakashiSato requested a review from ahcorde as a code owner May 6, 2024 12:14
@ahcorde ahcorde merged commit db4d8b0 into ros-controls:master May 6, 2024
4 of 8 checks passed
@ahcorde
Copy link
Collaborator

ahcorde commented May 6, 2024

https://github.com/Mergifyio backport humble iron

@mergify Mergify
Copy link
Contributor

mergify bot commented May 6, 2024 •
edited
Loading

backport humble iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 6, 2024
@TakashiSato @mergify
fixed target of ament_export_libraries (#295)
6476e99 
(cherry picked from commit db4d8b0)

# Conflicts:
#	gz_ros2_control/CMakeLists.txt
mergify bot pushed a commit that referenced this pull request May 6, 2024
@TakashiSato @mergify
fixed target of ament_export_libraries (#295)
63ff87b 
(cherry picked from commit db4d8b0)
This was referenced May 6, 2024
Closed
Merged
@ahcorde ahcorde mentioned this pull request May 6, 2024
Merged
ahcorde pushed a commit that referenced this pull request May 6, 2024
@mergify @TakashiSato
fixed target of ament_export_libraries (#295) (#299)
0f3aac9 
(cherry picked from commit db4d8b0)

Co-authored-by: Takashi Sato <t.sato17123@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TakashiSato @ahcorde