Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pendulum-example #301

Merged
merged 2 commits into from
May 13, 2024
Merged

Update pendulum-example #301

merged 2 commits into from
May 13, 2024

Conversation

christophfroehlich
Copy link
Contributor

For demonstration purposes, I change the initial pose to be in the lower equilibrium to make this clearer:
https://github.com/ros-controls/gazebo_ros2_control/assets/3367244/630cc8b8-6cb4-4dbc-9caa-948c085052e0

Originally posted by @christophfroehlich in ros-controls/gazebo_ros2_control#172 (comment)

and make position and effort variants equal, as requested here ros-controls/gazebo_ros2_control#172 (review)

@christophfroehlich
Copy link
Contributor Author

@Mergifyio backport humble iron

@mergify Mergify
Copy link
Contributor

mergify bot commented May 10, 2024 •
edited

backport humble iron

✅ Backports have been created

@ahcorde ahcorde merged commit 1e77214 into master May 13, 2024
4 of 5 checks passed
@ahcorde ahcorde deleted the change_pendulum_pose branch May 13, 2024 08:48
mergify bot pushed a commit that referenced this pull request May 13, 2024
@christophfroehlich @mergify
Update pendulum-example (#301)
c71d095 
* Change initial pose of pendulum

* Make position and effort version of pendulum equal

(cherry picked from commit 1e77214)
mergify bot pushed a commit that referenced this pull request May 13, 2024
@christophfroehlich @mergify
Update pendulum-example (#301)
1fc2c91 
* Change initial pose of pendulum

* Make position and effort version of pendulum equal

(cherry picked from commit 1e77214)
This was referenced May 13, 2024
Merged
Merged
ahcorde pushed a commit that referenced this pull request May 13, 2024
@mergify @christophfroehlich
Update pendulum-example (#301) (#303)
762c3d2 
* Change initial pose of pendulum

* Make position and effort version of pendulum equal

(cherry picked from commit 1e77214)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
ahcorde pushed a commit that referenced this pull request May 13, 2024
@mergify @christophfroehlich
Update pendulum-example (#301) (#304)
8a4b501 
* Change initial pose of pendulum

* Make position and effort version of pendulum equal

(cherry picked from commit 1e77214)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@christophfroehlich @ahcorde