Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove log-level argument from spawner script #1013

Merged
merged 1 commit into from
May 9, 2023

Conversation

bijoua29
Copy link
Contributor

@bijoua29 bijoua29 commented May 8, 2023

This change is to partially revert the changes in PR 972 which added a log-level argument to the spawner to control the output of the spawner node using the logging level. It turns out that using standard ros-args conventions for the 'ros2 run' command to set the logging level was sufficient.

So instead of adding a new way to set the logging level of the spawner with:

ros2 run controller_manager spawner --log-level WARN

the old way using ros-args was sufficient:

ros2 run controller_manager spawner --ros-args --log-level WARN

I have tested that this works.

Use standard ros-args instead
@codecov-commenter
Copy link

Codecov Report

Merging #1013 (4b6bbac) into master (925f5f3) will decrease coverage by 1.93%.
The diff coverage is 35.61%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1013      +/-   ##
==========================================
- Coverage   34.61%   32.69%   -1.93%     
==========================================
  Files          52       91      +39     
  Lines        2981     9551    +6570     
  Branches     1855     6432    +4577     
==========================================
+ Hits         1032     3123    +2091     
- Misses        310      704     +394     
- Partials     1639     5724    +4085     
Flag Coverage Δ
unittests 32.69% <35.61%> (-1.93%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controller_manager/src/controller_manager.cpp 38.27% <ø> (-1.44%) ⬇️
controller_manager/src/ros2_control_node.cpp 0.00% <0.00%> (ø)
..._interface/include/hardware_interface/actuator.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/sensor.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/system.hpp 100.00% <ø> (ø)
hardware_interface/src/resource_manager.cpp 49.91% <ø> (-3.72%) ⬇️
hardware_interface/src/sensor.cpp 50.52% <ø> (ø)
hardware_interface/src/system.cpp 55.45% <ø> (ø)
...rface/test/mock_components/test_generic_system.cpp 9.14% <ø> (ø)
...dware_interface/test/test_component_interfaces.cpp 32.44% <ø> (+4.25%) ⬆️
... and 68 more

... and 19 files with indirect coverage changes

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks reasonable!

@destogl destogl merged commit e3f38cc into ros-controls:master May 9, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants