Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CM] Optimize output when using robot description topic and give output about correct topic even remapped. #1059

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

destogl
Copy link
Member

@destogl destogl commented Jun 17, 2023

No description provided.

@destogl destogl self-assigned this Jun 17, 2023
@destogl destogl requested a review from bmagyar June 17, 2023 18:41
@codecov-commenter
Copy link

Codecov Report

Merging #1059 (ab33731) into master (925f5f3) will decrease coverage by 2.26%.
The diff coverage is 35.14%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1059      +/-   ##
==========================================
- Coverage   34.61%   32.36%   -2.26%     
==========================================
  Files          52       93      +41     
  Lines        2981     9795    +6814     
  Branches     1855     6599    +4744     
==========================================
+ Hits         1032     3170    +2138     
- Misses        310      777     +467     
- Partials     1639     5848    +4209     
Flag Coverage Δ
unittests 32.36% <35.14%> (-2.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controller_manager/src/controller_manager.cpp 38.04% <ø> (-1.67%) ⬇️
controller_manager/src/ros2_control_node.cpp 0.00% <0.00%> (ø)
..._interface/include/hardware_interface/actuator.hpp 100.00% <ø> (ø)
...ce/include/hardware_interface/async_components.hpp 0.00% <0.00%> (ø)
...re_interface/include/hardware_interface/sensor.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/system.hpp 100.00% <ø> (ø)
hardware_interface/src/resource_manager.cpp 47.32% <ø> (-6.30%) ⬇️
hardware_interface/src/sensor.cpp 50.52% <ø> (ø)
hardware_interface/src/system.cpp 55.45% <ø> (ø)
...rface/test/mock_components/test_generic_system.cpp 9.42% <ø> (ø)
... and 70 more

... and 19 files with indirect coverage changes

@bmagyar bmagyar merged commit dc01ae3 into master Jun 20, 2023
15 of 17 checks passed
@bmagyar bmagyar deleted the make-better-output-about-robot-description-topic branch December 4, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants