Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CM] Linting if/else statements #1193

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Conversation

destogl
Copy link
Member

@destogl destogl commented Dec 4, 2023

No description provided.

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #1193 (71f3bac) into master (6ca76cd) will increase coverage by 0.01%.
Report is 2 commits behind head on master.
The diff coverage is 60.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1193      +/-   ##
==========================================
+ Coverage   47.63%   47.65%   +0.01%     
==========================================
  Files          40       40              
  Lines        3445     3448       +3     
  Branches     1866     1867       +1     
==========================================
+ Hits         1641     1643       +2     
  Misses        480      480              
- Partials     1324     1325       +1     
Flag Coverage Δ
unittests 47.65% <60.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
controller_manager/src/controller_manager.cpp 38.78% <60.00%> (+0.07%) ⬆️

bmagyar
bmagyar previously approved these changes Dec 11, 2023
Copy link
Contributor

mergify bot commented Dec 11, 2023

This pull request is in conflict. Could you fix it @destogl?

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much good

@bmagyar bmagyar merged commit 51b8985 into ros-controls:master Dec 12, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants