-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add controller exception handling in controller manager #1507
Add controller exception handling in controller manager #1507
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very much needed feature 😁
There would be even more methods of the controller_interface
to handle, like the command_interface_configuration
which could also throw exceptions (during development, giving the user some better feedback).
Closes #451 |
Sure, I can take a look. I thought so of adding it, but then as it is only the The problem is this is present in many lines and I don't know if it is worth it. |
Ok i haven't checked the number of calls. Let it as it is.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grand, thank yoU!
This PR adds the exception handling in the controller manager for the most commonly used controller methods that are triggered by different controller manager services