Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add controller exception handling in controller manager #1507

Conversation

saikishor
Copy link
Member

This PR adds the exception handling in the controller manager for the most commonly used controller methods that are triggered by different controller manager services

@saikishor saikishor changed the title Add controllers exception handling in controller manager Add controller exception handling in controller manager Apr 25, 2024
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very much needed feature 😁

There would be even more methods of the controller_interface to handle, like the command_interface_configuration which could also throw exceptions (during development, giving the user some better feedback).

@christophfroehlich
Copy link
Contributor

Closes #451

@saikishor
Copy link
Member Author

This is a very much needed feature 😁

There would be even more methods of the controller_interface to handle, like the command_interface_configuration which could also throw exceptions (during development, giving the user some better feedback).

Sure, I can take a look. I thought so of adding it, but then as it is only the InterfaceConfiguration, which basically has a list and then the enum, that's the reason I didn't add it. The worst that could happen there is a Segmentation fault, which we cannot do anything anyway.

The problem is this is present in many lines and I don't know if it is worth it.

@christophfroehlich
Copy link
Contributor

Ok i haven't checked the number of calls. Let it as it is..

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grand, thank yoU!

@bmagyar bmagyar merged commit c935b50 into ros-controls:master May 3, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants