Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hardware components exception handling in resource manager #1508

Conversation

saikishor
Copy link
Member

This PR adds the exception handling in the resource manager for the most commonly used hardware component methods that are triggered during their lifecycle transition and communication cycles.

Similar to #1507

Copy link

codecov bot commented May 4, 2024

Codecov Report

Attention: Patch coverage is 52.51799% with 66 lines in your changes are missing coverage. Please review.

Project coverage is 87.72%. Comparing base (7fdf472) to head (670917d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1508      +/-   ##
==========================================
- Coverage   88.42%   87.72%   -0.71%     
==========================================
  Files         101      101              
  Lines        8349     8426      +77     
  Branches      728      732       +4     
==========================================
+ Hits         7383     7392       +9     
- Misses        703      767      +64     
- Partials      263      267       +4     
Flag Coverage Δ
unittests 87.72% <52.51%> (-0.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
hardware_interface/src/resource_manager.cpp 71.30% <52.51%> (-7.41%) ⬇️

@bmagyar
Copy link
Member

bmagyar commented May 4, 2024

Is it possible to test this in any other way then defining a whole bunch of new test classes?

I'm thinking about setting up a mocker that throws on every call:
https://stackoverflow.com/a/61899414

@saikishor
Copy link
Member Author

Is it possible to test this in any other way then defining a whole bunch of new test classes?

I'm thinking about setting up a mocker that throws on every call: https://stackoverflow.com/a/61899414

@bmagyar It's a very nice idea. do you want me to do it in this PR, or can I add it in a separate PR in the upcoming days, in the meantime, we can create an issue from your comment and I can assign it to me.

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bmagyar bmagyar merged commit 7090f41 into ros-controls:master May 8, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants