Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide component parser api #157

Merged
merged 2 commits into from Sep 22, 2020
Merged

Hide component parser api #157

merged 2 commits into from Sep 22, 2020

Conversation

Karsten1987
Copy link
Contributor

as per title.

the public API of the component parser currently introduces details, which are not necessary. Essentially hides tinyxml2.
The diff looks more funky than it actually is. The .cpp file got a namespace detail and all tinyxml related functions are part of it. No code got modified.

Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

Merging #157 into master will not change coverage.
The diff coverage is 40.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #157   +/-   ##
=======================================
  Coverage   36.61%   36.61%           
=======================================
  Files          42       42           
  Lines        1726     1726           
  Branches     1080     1080           
=======================================
  Hits          632      632           
  Misses        100      100           
  Partials      994      994           
Flag Coverage Δ
#unittests 36.61% <40.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hardware_interface/src/component_parser.cpp 41.30% <40.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a25721...e2844e3. Read the comment docs.

@bmagyar bmagyar self-requested a review September 22, 2020 07:08
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up for reducing exported interfaces

@bmagyar bmagyar merged commit cfa8121 into master Sep 22, 2020
@Karsten1987 Karsten1987 deleted the hide_component_parser_api branch September 22, 2020 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants