Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Member function naming in system_interface.cpp #269

Closed
AndyZe opened this issue Dec 14, 2020 · 3 comments
Closed

Member function naming in system_interface.cpp #269

AndyZe opened this issue Dec 14, 2020 · 3 comments

Comments

@AndyZe
Copy link
Contributor

AndyZe commented Dec 14, 2020

These member functions defy the Google style guidelines and the ROS C++ style guidelines. Was that intentional or should we change them?

hardware_interface/system_interface.hpp

For example, export_state_interfaces() should be exportStateInterfaces() per ROS1 style

Google style guide: https://google.github.io/styleguide/cppguide.html#General_Naming_Rules
ROS1 style guide: http://wiki.ros.org/CppStyleGuide#Function_.2F_Methods

I'm happy to make a cleanup PR if needed

@AndyZe
Copy link
Contributor Author

AndyZe commented Dec 14, 2020

It looks like this is pretty widespread throughout the codebase

@gavanderhoorn
Copy link

ROS 2 C++ code style allows snake_case.

From Code style and language versions - C++ - Style: Function and Method Naming:

image

@AndyZe
Copy link
Contributor Author

AndyZe commented Dec 14, 2020

Cool. Maintainers, feel free to close the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants