We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
These member functions defy the Google style guidelines and the ROS C++ style guidelines. Was that intentional or should we change them?
hardware_interface/system_interface.hpp
For example, export_state_interfaces() should be exportStateInterfaces() per ROS1 style
export_state_interfaces()
exportStateInterfaces()
Google style guide: https://google.github.io/styleguide/cppguide.html#General_Naming_Rules ROS1 style guide: http://wiki.ros.org/CppStyleGuide#Function_.2F_Methods
I'm happy to make a cleanup PR if needed
The text was updated successfully, but these errors were encountered:
It looks like this is pretty widespread throughout the codebase
Sorry, something went wrong.
ROS 2 C++ code style allows snake_case.
snake_case
From Code style and language versions - C++ - Style: Function and Method Naming:
Cool. Maintainers, feel free to close the issue
No branches or pull requests
These member functions defy the Google style guidelines and the ROS C++ style guidelines. Was that intentional or should we change them?
hardware_interface/system_interface.hpp
For example,
export_state_interfaces()
should beexportStateInterfaces()
per ROS1 styleGoogle style guide: https://google.github.io/styleguide/cppguide.html#General_Naming_Rules
ROS1 style guide: http://wiki.ros.org/CppStyleGuide#Function_.2F_Methods
I'm happy to make a cleanup PR if needed
The text was updated successfully, but these errors were encountered: