Capitalized messages in controller_manager.cpp upto line669 #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
destogl
requested changes
Jan 1, 2021
Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>
bmagyar
reviewed
Jan 25, 2021
bmagyar
approved these changes
Jan 25, 2021
There was a problem hiding this comment.
Thanks @Achinta-Choudhury and @destogl , feel free to continue this effort on a new PR, I'm merging this one!
destogl
approved these changes
Jan 26, 2021
There was a problem hiding this comment.
@Achinta-Choudhury thank you for your contribution. Let's merge as it is.
destogl
reviewed
Jan 26, 2021
destogl
reviewed
Jan 26, 2021
|
@bmagyar please check my changes one more time and if OK merge. |
destogl
reviewed
Jan 26, 2021
bmagyar
reviewed
Jan 27, 2021
destogl
reviewed
Jan 27, 2021
mahaarbo
pushed a commit
to mahaarbo/ros2_control
that referenced
this pull request
Feb 4, 2021
…rols#285) * Capitalized messages in controller_manager.cpp up to line669 Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com> Co-authored-by: Denis Štogl <destogl@users.noreply.github.com>
destogl
added a commit
to StoglRobotics-forks/ros2_control
that referenced
this pull request
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should I proceed the rest of the project with similar changes ?