Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inverse the response of cli commands to return correct exit-status. #308

Merged
merged 2 commits into from
Jan 28, 2021
Merged

Inverse the response of cli commands to return correct exit-status. #308

merged 2 commits into from
Jan 28, 2021

Conversation

ShotaAk
Copy link
Contributor

@ShotaAk ShotaAk commented Jan 26, 2021

Fix #306 .

bmagyar
bmagyar approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks @ShotaAk !

@destogl
Copy link
Member

destogl commented Jan 26, 2021 •
edited
Loading

@ShotaAk could you also extend this functionality to other verbs also? So that each verb returns success/failure values.

@ShotaAk
Copy link
Contributor Author

ShotaAk commented Jan 26, 2021 •
edited
Loading

@destogl Do you mean list* verbs right?
Since there are no response ok in List*.srv files, I will insert return 0 to each list verbs. Is it OK?

@destogl destogl mentioned this pull request Jan 26, 2021
Merged
@bmagyar
Copy link
Member

bmagyar commented Jan 28, 2021

Thanks for the contribution @ShotaAk !

@bmagyar bmagyar merged commit 654c51d into ros-controls:master Jan 28, 2021
mahaarbo pushed a commit to mahaarbo/ros2_control that referenced this pull request Feb 4, 2021
@ShotaAk @mahaarbo
Inverse the response of cli commands to return correct exit-status. (r…
87370ef 
…os-controls#308)

* Inverse the response of cli commands to return correct exit-status.

* list verbs return exit-status 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmagyar bmagyar bmagyar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some cli commands return '1' even through it's successfully executed
3 participants
@ShotaAk @destogl @bmagyar