[python] Update files in ros2controlcli to use format strings #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NovusEdge
changed the title
NovusEdge
changed the title
Closed
|
@NovusEdge This looks great thanks! Did you also test it? |
|
@destogl |
|
@NovusEdge I am guessing you are new in ros2_control and would like to learn more about the framework. Am I right? If so, I propose to check out ros-controls/ros2_control_demos and test the call using rrbot demo hardware. Also, before doing anything further with this PR, you should check these errors with linters. |
destogl
previously requested changes
Apr 2, 2021
|
@NovusEdge friendly ping. Are you still working on this? |
I currently can't work on it. So, no. |
bmagyar
reviewed
Apr 27, 2021
bmagyar
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #355
@bmagyar
Please be sure to review the changes and let me know if something is wrong; or if more changes are to be made.